From 4a19d58329969a7fe9290f93eb438fd85e70324c Mon Sep 17 00:00:00 2001 From: Jason Robbins Date: Wed, 30 Oct 2024 14:07:40 -0700 Subject: [PATCH] Change chrome://flags to about://flags in help text (#4502) * Change chrome://flags to about://flags in help text * Also change it in the intent templates and goldens --- client-src/elements/form-field-specs.ts | 2 +- internals/testdata/notifier_test/test_make_intent_email.html | 2 +- pages/testdata/intentpreview_test/test_html_rendering.html | 2 +- templates/blink/intent_to_implement.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client-src/elements/form-field-specs.ts b/client-src/elements/form-field-specs.ts index f9ec1c825ec4..93f7684f6df1 100644 --- a/client-src/elements/form-field-specs.ts +++ b/client-src/elements/form-field-specs.ts @@ -1926,7 +1926,7 @@ export const ALL_FIELDS: Record = { attrs: TEXT_FIELD_ATTRS, required: false, label: 'Flag name', - help_text: html` Name of the flag on chrome://flags that allows a web + help_text: html` Name of the flag on about://flags that allows a web developer to enable this feature in their own browser to try it out. E.g., "storage-buckets". These are defined in Contact emails -

Flag name on chrome://flags

+

Flag name on about://flags

None

Finch feature name

diff --git a/pages/testdata/intentpreview_test/test_html_rendering.html b/pages/testdata/intentpreview_test/test_html_rendering.html index 5ad862641d36..4fbe731ac4d4 100644 --- a/pages/testdata/intentpreview_test/test_html_rendering.html +++ b/pages/testdata/intentpreview_test/test_html_rendering.html @@ -258,7 +258,7 @@

Contact emails

-

Flag name on chrome://flags

+

Flag name on about://flags

None

Finch feature name

diff --git a/templates/blink/intent_to_implement.html b/templates/blink/intent_to_implement.html index ce7f6800699b..8bc4c1262115 100644 --- a/templates/blink/intent_to_implement.html +++ b/templates/blink/intent_to_implement.html @@ -179,7 +179,7 @@

Contact emails

>{{feature.devtrial_instructions}}
{% endif %} -

Flag name on chrome://flags

+

Flag name on about://flags

{{feature.flag_name}}

Finch feature name