From 85aa6e2b01287b5dc93c2da0cf7e334955dc495d Mon Sep 17 00:00:00 2001 From: Jason Robbins Date: Wed, 16 Oct 2024 11:14:38 -0700 Subject: [PATCH] Add omole as an enterprise reviewer. (#4450) * Add omole as an enterprise reviewer. * updated tests --- internals/approval_defs.py | 1 + internals/reminders_test.py | 15 +++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/internals/approval_defs.py b/internals/approval_defs.py index 6a1756e184ad..db71474f2654 100644 --- a/internals/approval_defs.py +++ b/internals/approval_defs.py @@ -44,6 +44,7 @@ 'mhoste@google.com', 'angelaweber@google.com', 'davidayad@google.com', + 'omole@google.com', ] DEBUGGABILITY_APPROVERS = IN_NDB TESTING_APPROVERS = [ diff --git a/internals/reminders_test.py b/internals/reminders_test.py index 0db14af58c15..2902e3e403a2 100644 --- a/internals/reminders_test.py +++ b/internals/reminders_test.py @@ -400,11 +400,12 @@ def test_get_template_data__one_due_unassigned(self, mock_remaining_days): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'3 email(s) sent or logged.\n' + expected_message = (f'4 email(s) sent or logged.\n' 'Recipients:\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' - 'mhoste@google.com') + 'mhoste@google.com\n' + 'omole@google.com') expected = {'message': expected_message} self.assertEqual(actual, expected) @@ -437,11 +438,12 @@ def test_get_template_data__one_overdue_unassigned(self, mock_remaining_days): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'3 email(s) sent or logged.\n' + expected_message = (f'4 email(s) sent or logged.\n' 'Recipients:\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' - 'mhoste@google.com') + 'mhoste@google.com\n' + 'omole@google.com') expected = {'message': expected_message} self.assertEqual(actual, expected) @@ -457,12 +459,13 @@ def test_get_template_data__one_overdue_assigned(self, mock_remaining_days): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'4 email(s) sent or logged.\n' + expected_message = (f'5 email(s) sent or logged.\n' 'Recipients:\n' 'a_assignee@example.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' - 'mhoste@google.com') + 'mhoste@google.com\n' + 'omole@google.com') expected = {'message': expected_message} self.assertEqual(actual, expected)