Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something if an invalid category is provided #16085

Open
G-Rath opened this issue Jun 22, 2024 · 0 comments
Open

Do something if an invalid category is provided #16085

G-Rath opened this issue Jun 22, 2024 · 0 comments
Assignees

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Jun 22, 2024

Feature request summary

It seems like currently the CLI does not validate the actual categories provided for --only-categories - this tripped us up as we were using the PWA category which has since been removed, and so our RSpec matcher started to bomb out.

This has lead to a round of improvements for our matcher which including explicitly checking that the category is present in the output before trying to extract the score, but it occurred to me that it could be useful for everyone if the CLI itself was to better hint at this - even if it was just to add an entry to runWarnings, that could be helpful.

What is the motivation or use case for changing this?

Reduce confusion, making lives easier, etc

How is this beneficial to Lighthouse?

Make it easier for folks to update to newer versions since they can be confident they'll know if a category they're depending on suddenly goes away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants