Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations #16313

Open
3 tasks done
Mbb640 opened this issue Jan 23, 2025 · 1 comment
Open
3 tasks done

Missing translations #16313

Mbb640 opened this issue Jan 23, 2025 · 1 comment
Assignees
Labels
bug i18n internationalization thangs P1.5

Comments

@Mbb640
Copy link

Mbb640 commented Jan 23, 2025

FAQ

URL

Site-agnostic (screenshots taken from local build, doublechecked on google.ca)

What happened?

When generating reports in French, titles of all performance metrics remain in English.

Image

When generating reports in Spanish, there is a similar issue - though some of the missing French translations are available in Spanish.

Image

What did you expect?

Translations that are supported should be complete.

What have you tried?

No response

How were you running Lighthouse?

CLI

Lighthouse Version

12.3

Chrome Version

No response

Node Version

No response

OS

No response

Relevant log output

@adamraine
Copy link
Member

The French translations are actually correct here. We don't want to translate these because they are names.

Maybe we shouldn't even send these through the translation pipeline.

@adamraine adamraine added P1.5 i18n internationalization thangs labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n internationalization thangs P1.5
Projects
None yet
Development

No branches or pull requests

3 participants