Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_storage_service_benchmark Unexpected test outcome from OneByteRW #5427

Closed
pdeyhim opened this issue Dec 6, 2024 · 1 comment · Fixed by #5542
Closed

object_storage_service_benchmark Unexpected test outcome from OneByteRW #5427

pdeyhim opened this issue Dec 6, 2024 · 1 comment · Fixed by #5542
Assignees

Comments

@pdeyhim
Copy link

pdeyhim commented Dec 6, 2024

Command: pkb.py --benchmarks object_storage_service --cloud=AWS --object_storage_region us-west-2 --benchmark_config_file=config

I've seen this error in the previous versions and I vaguely remember I had to change the regex logic.

Traceback (most recent call last):
File "/Users/parviz.deyhim/dev/junk/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 1352, in RunBenchmarkTask
RunBenchmark(spec_for_run, collector)
File "/Users/parviz.deyhim/dev/junk/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 1085, in RunBenchmark
DoRunPhase(spec, collector, detailed_timer)
File "/Users/parviz.deyhim/dev/junk/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 786, in DoRunPhase
samples = spec.BenchmarkRun(spec)
^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/parviz.deyhim/dev/junk/PerfKitBenchmarker/perfkitbenchmarker/linux_benchmarks/object_storage_service_benchmark.py", line 1959, in Run
benchmark(
File "/Users/parviz.deyhim/dev/junk/PerfKitBenchmarker/perfkitbenchmarker/linux_benchmarks/object_storage_service_benchmark.py", line 935, in OneByteRWBenchmark
raise ValueError(
ValueError: Unexpected test outcome from OneByteRW api test: INFO:root:Storage provider is S3, bucket is pkb6499a05c, scenario is OneByteRW
INFO:botocore.credentials:Found credentials from IAM Role: test
INFO:root:Individual results of one byte upload:
INFO:root:0.074227
INFO:root:0.016868
INFO:root:0.015615
INFO:root:0.016691
INFO:root:0.018713
INFO:root:0.017808
INFO:root:0.017709
INFO:root:0.019638
.....

@pdeyhim
Copy link
Author

pdeyhim commented Dec 6, 2024

search string ends up being: One byte MultistreamOperationType.upload

not sure why enum is not getting converted

copybara-service bot pushed a commit that referenced this issue Jan 30, 2025
1. Fix enums to render correctly in Python 3.11 (fixes #5427)
2. Fix cleanup for scenarios besides api_multistream.
3. Default scenario to api_multistream.

We have only been running with scenario=api_multistream for a number of years and that has caused bugs to accumulate in the other scenarios.

PiperOrigin-RevId: 718545259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants