This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Design: split build/deploy and test topics #533
Labels
ignore-for-release
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Context
Emblem has several CI processes that run on a nightly basis. These are triggered by Cloud Scheduler, which sends a message to Pub/Sub that in turn triggers Cloud Build:
Problem Statement
Currently, we use one Pub/Sub topic (
nightly
) to trigger both builds/deploys and tests.This means that artifact builds/deploys and tests are triggered [by Cloud Scheduler] simultaneously. Simultaneous triggering can lead to race conditions, wherein tests on day
n
will test dayn-1
's deployment artifacts.Proposed Fix
To mitigate this, we should create two Pub/Sub topics:
nightly-builds
: build artifactsnightly-tests
: run testsThe build topic (
nightly-builds
) will run slightly (e.g. 1 hour) before the testing topic (nightly-tests
). This should give the builds enough time to update the deployed artifacts.Implementation
To implement this change, we'll need to do the following:
nightly-builds
andnightly-tests
)nightly
) Pub/Sub topic and any references to it.Tip: each of these should be one PR, for three PRs total.
The text was updated successfully, but these errors were encountered: