Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

ensure setup.sh idempotence #735

Open
rogerthatdev opened this issue Dec 13, 2022 · 1 comment
Open

ensure setup.sh idempotence #735

rogerthatdev opened this issue Dec 13, 2022 · 1 comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@rogerthatdev
Copy link
Contributor

Problem

setup.sh does not gracefully allow itself to be run twice.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Run setup.sh
  2. Run it again

Expected behavior

There should be logic that allows setup.sh to run more than once without error.

An accompanying bash test would ensure this remains a requirement for all changes to setup script.
@rogerthatdev rogerthatdev added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 13, 2022
@ace-n
Copy link
Contributor

ace-n commented Dec 13, 2022

Example fix as of December 13th, 2022

@grayside grayside added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grayside @ace-n @rogerthatdev