Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

trigger using unit-tests.cloudbuild.yaml does not fail on step 2 #753

Open
rogerthatdev opened this issue Jan 5, 2023 · 0 comments
Open
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@rogerthatdev
Copy link
Contributor

Thanks for stopping by to let us know something could be better!

PLEASE READ: This repository is dedicated to a sample application that uses multiple Google Cloud products. We will only be able to address issues related to this application, not to underlying issues in a client library or one of the products. Please visit the Support page to reach the most relevant engineers.

Problem

Unit tests that run via cloud build using unit-tests.cloudbuild.yaml do not fail at step 2 when a token is not retrieved successfully.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Initiate the api-unit-tests trigger by creating a PR that makes changes to content-api/**
  2. If fails, see that step 2 is marked as successful

Expected behavior

If a token is not retrieved, the build should fail at step 2.

Step 2 retrieves a token via bash and pipes it to python. It should either pipe only to more bash, or be passed along to another step that will execute the python, if required.

@rogerthatdev rogerthatdev added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 5, 2023
@rogerthatdev rogerthatdev added type: process A process-related concern. May include testing, release, or the like. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

1 participant