From fa24a26ce9a0ad90efc8771472c7c1c57393cc9f Mon Sep 17 00:00:00 2001 From: Valentin Deleplace Date: Thu, 18 Jul 2024 21:49:35 +0200 Subject: [PATCH] fix(translate): Serbian expected translation (#4251) --- translate/v3/translate_text_test.go | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/translate/v3/translate_text_test.go b/translate/v3/translate_text_test.go index af4a9cd43a..434a7ea7ff 100644 --- a/translate/v3/translate_text_test.go +++ b/translate/v3/translate_text_test.go @@ -23,7 +23,6 @@ import ( ) func TestTranslateText(t *testing.T) { - t.Skip("Skipped while investigating https://github.com/GoogleCloudPlatform/golang-samples/issues/2811") tc := testutil.SystemTest(t) sourceLang := "en-US" @@ -35,7 +34,15 @@ func TestTranslateText(t *testing.T) { if err := translateText(&buf, tc.ProjectID, sourceLang, targetLang, text); err != nil { t.Fatalf("translateText: %v", err) } - if got, want1, want2 := buf.String(), "Zdravo", "Pozdrav"; !strings.Contains(got, want1) && !strings.Contains(got, want2) { - t.Errorf("translateText got:\n----\n%s----\nWant to contain:\n----\n%s\n----\nOR\n----\n%s\n----", got, want1, want2) + // Acceptable answers look like: + // "Zdravo Svete" + // "Здраво Свете" + lower := strings.ToLower(buf.String()) + ok := strings.Contains(lower, "zdravo") || + strings.Contains(lower, "svete") || + strings.Contains(lower, "здраво") || + strings.Contains(lower, "свете") + if got, want1, want2 := buf.String(), "Zdravo Svete", "Здраво Свете"; !ok { + t.Errorf("translateText got:\n----\n%s----\nWant:\n----\n%s\n----\nOR\n----\n%s\n----", got, want1, want2) } }