Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate instructions on GCP onboarding, roles, service enablements, billing and bootstrap project - continuation of 362 #407

Closed
obriensystems opened this issue Apr 27, 2024 · 1 comment

Comments

@obriensystems
Copy link
Collaborator

obriensystems commented Apr 27, 2024

PR additionally upstream via terraform-google-modules/terraform-example-foundation#1204

specifically the prerequisites sections with roles and service enablements duplicated across
"For the user who will run the procedures in this document, grant the following roles:"
and
"Enable the following additional services on your current bootstrap project"

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/0-bootstrap/README.md#prerequisites
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/0-bootstrap/README-Terraform-Cloud.md#requirements
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/0-bootstrap/README-GitLab.md#deploying-a-gitlab-cicd-compatible-environment
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/0-bootstrap/README-GitHub.md#requirements

no section in
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/0-bootstrap/README-Jenkins.md

Check each terraform module specific to the build agent - for example

Fix:
detail all common roles and service enablements in the main readme, put links back to this readme from the extended readme's and add specific roles/services per gitlab/github/terraform-cloud/ado in extended readme's

see

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant