You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Default build priority doesn't cover all the supported build methods, and incorrectly prioritizes Dockerfiles over Jib for Java.
Current Practice
README command
Dockerfile
Jib
Preferred
README command
Jib
Dockerfile
Notes on the preferred ordering:
Jib is the primary recommendation for building Java containers in Cloud Run. Jib may be configured in a project to use a Dockerfile to create a base image.
This raises a secondary problem: what if it's a Java project that wants to build from a Dockerfile, not use jib?
This issue affects two categories in my review of the repository:
Correctness: Is the implemented business logic correct?
Scope: Does the tool have the breadth of features and flexibility to support reasonable testing needs?
The text was updated successfully, but these errors were encountered:
With regards to users wanting to build a java sample without jib, I think we can force them to use a method outside of reasonable defaults to specify their build and deploy commands (i.e. Cloud Build configuration, when that's implemented). Or we can implement a --no-jib flag as well.
Default build priority doesn't cover all the supported build methods, and incorrectly prioritizes Dockerfiles over Jib for Java.
Current Practice
Preferred
Notes on the preferred ordering:
This raises a secondary problem: what if it's a Java project that wants to build from a Dockerfile, not use jib?
This issue affects two categories in my review of the repository:
The text was updated successfully, but these errors were encountered: