Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Fix default build mechanism priority for jib #7

Open
grayside opened this issue Aug 10, 2020 · 1 comment · May be fixed by #28
Open

Fix default build mechanism priority for jib #7

grayside opened this issue Aug 10, 2020 · 1 comment · May be fixed by #28

Comments

@grayside
Copy link

Default build priority doesn't cover all the supported build methods, and incorrectly prioritizes Dockerfiles over Jib for Java.

Current Practice

  • README command
  • Dockerfile
  • Jib

Preferred

  • README command
  • Jib
  • Dockerfile

Notes on the preferred ordering:

  • Jib is the primary recommendation for building Java containers in Cloud Run. Jib may be configured in a project to use a Dockerfile to create a base image.

This raises a secondary problem: what if it's a Java project that wants to build from a Dockerfile, not use jib?

This issue affects two categories in my review of the repository:

  • Correctness: Is the implemented business logic correct?
  • Scope: Does the tool have the breadth of features and flexibility to support reasonable testing needs?
@SaketramDurbha
Copy link
Contributor

SaketramDurbha commented Aug 10, 2020

Draft implementation here: https://github.com/SaketramDurbha/serverless-sample-tester/tree/i7 .

With regards to users wanting to build a java sample without jib, I think we can force them to use a method outside of reasonable defaults to specify their build and deploy commands (i.e. Cloud Build configuration, when that's implemented). Or we can implement a --no-jib flag as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants