Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test framework does not expose Envoy-provided pseudo headers by default #10

Open
leonm1 opened this issue May 30, 2023 · 1 comment
Open

Comments

@leonm1
Copy link
Contributor

leonm1 commented May 30, 2023

This is a feature request from #1:

The test framework does not expose pseudo-headers like :path for the provided wasm module to manipulate.

The headers passed to the wasm module by the test fixture are exactly what the test author provides to TestHttpContext::SendRequestHeaders, so the easy fix is to pass the :path pseudo-header in the call to SendRequestHeaders.

The longer-term feature request here is for SendRequestHeaders to take in the fields represented as pseudo-headers and supply them to the wasm module via the correct pseudo-headers.

As a whole the testing framework right now is designed to be as transparent as possible to let the test author control the environment passed to the wasm module. Lightweight test frameworks are useful for authors understanding the environment their code is running in and removes friction while writing tests, but I can also understand the desire for the test framework to provide a more comprehensive way of testing against the behavior of the GCP service. We will discuss this tradeoff at our next meeting.

@leonm1 leonm1 changed the title Test framework does not expose Envoy-provided pseudo headers by Test framework does not expose Envoy-provided pseudo headers by default May 30, 2023
@martijneken
Copy link
Collaborator

Is this issue still relevant? I added an HTTP1 parser to the test framework in #91, which I think addresses the concern of converting from HTTP1 headers to HTTP2 headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants