-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rules_rust target selection #31
Comments
This might be the crux of the issue. Because we're using the ProxyWasm transition for rust_binary targets, perhaps the overall build (and thus crates_repository) does not have a wasm platform set. Then again, providing the platform at the command line does not fix this: And the transition explicitly sets the platform: |
Workaround applied in #36 |
I bet the wasi_rust_binary_rule would work (it explicitly gets a platform attribute in the transition), but the rust_binary() rule here does not have a platform set (hence target platform |
Actual Behavior
All the generated Cargo targets have the same problem:
Somehow we are not setting target platform correctly? We should be, via this
rust_binary
transition:https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/master/bazel/wasm.bzl
Steps to Reproduce the Problem
target_compatible_with
added toCommonAttrs
bazelbuild/rules_rust#1976Workaround: set
generate_target_compatible_with = False
The text was updated successfully, but these errors were encountered: