Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Rust logging behavior in samples #37

Open
martijneken opened this issue Feb 9, 2024 · 1 comment
Open

Clarify Rust logging behavior in samples #37

martijneken opened this issue Feb 9, 2024 · 1 comment

Comments

@martijneken
Copy link
Collaborator

All our Rust plugin samples have this line, with no explanation:
proxy_wasm::set_log_level(LogLevel::Trace);

This is extra confusing because Service Extensions has its own min_log_level config which applies to all wasm logging.

Task: use code comments to clarify why the code is needed.

The code is needed because:

@martijneken
Copy link
Collaborator Author

Consider also updating the Rust SDK to set a non-off log level default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant