Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when generating new dist version #91

Open
steren opened this issue May 1, 2021 · 4 comments
Open

Error when generating new dist version #91

steren opened this issue May 1, 2021 · 4 comments

Comments

@steren
Copy link
Collaborator

steren commented May 1, 2021

I tried generating a new version with npm run dist, but I got:

$ npm run dist

> [email protected] dist /workspaces/stackdriver-errors-js
> gulp lib-concat

fs.js:45
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:45:5
    at req_ (/workspaces/stackdriver-errors-js/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/workspaces/stackdriver-errors-js/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/workspaces/stackdriver-errors-js/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] dist: `gulp lib-concat`
npm ERR! Exit status 1
@steren
Copy link
Collaborator Author

steren commented May 1, 2021

I don't have much time to troubleshoot, if anyone wants to take a look, please do (CC @jmasukawa)

@jmasukawa
Copy link
Contributor

I actually ran into this while trying to run the unit tests locally. I ended up using an older version of node that was compatible with gulp v3.x. Try out node v10.x?

Source: https://stackoverflow.com/q/55921442

By the way, I was using NVM on my workstation so it was easy to switch versions: https://github.com/nvm-sh/nvm

@steren
Copy link
Collaborator Author

steren commented May 21, 2021

I'd rather update the dist and test codebase to be compatible with recent node.js version.

Is this something you could help @jmasukawa ?

After that, I can cut a new module version

@jmasukawa
Copy link
Contributor

jmasukawa commented May 21, 2021

Yeah that makes sense, ~~I can give it a shot sometime this coming week. 👍 ~~

Update: clearly I didn't find time to do this. 🙁

@steren maybe don't count on me to handle this anymore. 🙂 We found that stackdriver-errors-js reports errors with obfuscated stacktraces in a production web apps, so we need something custom anyways, and won't be using stackdriver-errors-js anymore. As a result, my personal investment in this has been...diminished. 😅 Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants