Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Submit button type #1334

Closed
ArakTaiRoth opened this issue Aug 22, 2023 · 3 comments
Closed

Spike: Submit button type #1334

ArakTaiRoth opened this issue Aug 22, 2023 · 3 comments
Labels
Spike Label to use for Spikes

Comments

@ArakTaiRoth
Copy link
Collaborator

Info

Currently when people use the submit button type it currently creates that type of button, but it doesn't actually function as a submit button type. What this means is that forms cannot be submitted a normal way by hitting enter within an input area. This isn't as big of a deal for large forms, but for things like search forms with only one input and a button, this completely changes how people will normally interact with the form.

Acceptance Criteria:

  1. Determine if there's anything we can do to make the submit button type actually function as it should.

There is a story to deprecate the submit button type - #1321 - If something comes out of this Spike, then this story might be modified to make those changes instead of deprecating it.

This is a link to a description of the issue and why it doesn't currently work for us.

@ArakTaiRoth ArakTaiRoth added the Spike Label to use for Spikes label Aug 22, 2023
@ArakTaiRoth ArakTaiRoth moved this to 📋 Backlog in Design System Backlog Aug 30, 2023
@Spark450
Copy link
Collaborator

@ArakTaiRoth Do you think there is some functionality is Svelte 4 or 5 that might help us enable this? If so, would it make sense to revisit once we are able to upgrade?

@ArakTaiRoth
Copy link
Collaborator Author

Wait on this until we have upgraded Svelte, after we have moved to the Website.

@ArakTaiRoth
Copy link
Collaborator Author

Closing as not needed any longer, after onKeyPress functionality

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Design System Backlog Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spike Label to use for Spikes
Projects
Archived in project
Development

No branches or pull requests

2 participants