Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Table's width property is incorrectly described #1465

Closed
vanessatran-ddi opened this issue Nov 15, 2023 · 0 comments · Fixed by #1470
Closed

[Documentation]: Table's width property is incorrectly described #1465

vanessatran-ddi opened this issue Nov 15, 2023 · 0 comments · Fixed by #1470
Assignees
Labels
Documentation Improvements or additions to documentation

Comments

@vanessatran-ddi
Copy link
Collaborator

Describe the bug

https://ui-components.alberta.ca/?path=/docs/components-table--basic

It is said that: width: Width of the table. By default it will fit the enclosed content.

However, the basic table width is always smaller than the parent div.
image

Provide Code

https://github.com/GovAlta/ui-components-docs/blob/main/src/components/component-properties/ComponentProperties.tsx#L49

<GoATable variant="relaxed">
        <thead>
          <tr>
            <th>Name</th>
            <th>Type</th>
            <th>Description</th>
            <th>Default</th>
          </tr>
        </thead>
        <tbody>{rows(filteredProperties)}</tbody>
      </GoATable>

To Reproduce

Link

Relevant console log output

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

@vanessatran-ddi vanessatran-ddi added the Bug Something isn't working label Nov 15, 2023
@ArakTaiRoth ArakTaiRoth self-assigned this Nov 15, 2023
@ArakTaiRoth ArakTaiRoth added Documentation Improvements or additions to documentation and removed Bug Something isn't working labels Nov 15, 2023
@ArakTaiRoth ArakTaiRoth moved this to 🏗 In progress in Design System Backlog Nov 15, 2023
@ArakTaiRoth ArakTaiRoth changed the title [Bug]: Table's width doesn't fit the enclosed content as default [Documentation]: Table's width property is incorrectly described Nov 15, 2023
@ArakTaiRoth ArakTaiRoth linked a pull request Nov 15, 2023 that will close this issue
@ArakTaiRoth ArakTaiRoth moved this from 🏗 In progress to Testing in Design System Backlog Nov 15, 2023
@ArakTaiRoth ArakTaiRoth moved this from Testing to 👀 In review in Design System Backlog Nov 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Backlog Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants