Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs in the settings screen does not follow material design used by other parts of the app #203

Open
octocorvus opened this issue Sep 7, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@octocorvus
Copy link
Member

No description provided.

@quh4gko8
Copy link
Member

This will require overhaul on library used on Settings section of the app, or rewrite on dialogs used anywhere else in the app

@thestinger thestinger added the enhancement New feature or request label Jan 8, 2023
@thestinger
Copy link
Member

Is this still an issue?

@girlbossceo
Copy link
Contributor

@thestinger The colours match Material You, but this doesn't look like a Material list preference dialog and looks like a compat one.

Screenshot_20230107-231857.png

What other dialogs look like:

Screenshot_20230107-235158.png

@girlbossceo
Copy link
Contributor

Yeah the release channel one is using a Material alert dialog. https://github.com/GrapheneOS/Apps/blob/c22055401aa14b84171b2d641a6e72d0c6e26725/app/src/main/java/app/grapheneos/apps/ui/ReleaseChannelDialog.kt#L24

Not sure what the other one is using but it's definitely not the same.

@octocorvus
Copy link
Member Author

Relevant discussion material-components/material-components-android#2732

@sivansundar
Copy link
Contributor

Is anybody working on this? If not, can I give it a shot?

@empratyush empratyush self-assigned this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants