Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant get enough tokens from transfer #390

Open
WeiyuSun opened this issue Aug 10, 2023 · 1 comment
Open

Cant get enough tokens from transfer #390

WeiyuSun opened this issue Aug 10, 2023 · 1 comment
Assignees

Comments

@WeiyuSun
Copy link
Contributor

WeiyuSun commented Aug 10, 2023

/transfers/${transfer_id}/accept
/transfers/${tansfer_id}/fullfill
when the user tries to accept specific tokens in a transfer. If the selected tokens are missing for some unknown reason. The transfer can still be accepted. But missing tokens cannot be transferred, which means the target wallet cannot get enough tokens from this transfer. This also happened in the fulfill specific tokens request.

How to solve?
Check the number of pending tokens for this transfer before finishing this transfer. If the token amount is smaller than the transfer required, return an appropriate message and state code for user.

@WeiyuSun
Copy link
Contributor Author

I can take this. Can you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant