Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lng to lon for consistancy #1162

Closed
RubenSmn opened this issue Nov 1, 2022 · 5 comments
Closed

Update lng to lon for consistancy #1162

RubenSmn opened this issue Nov 1, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@RubenSmn
Copy link
Member

RubenSmn commented Nov 1, 2022

Description

Currently we are using both lon and lng in our code.
For consistancy we should update lng to lon since it is the most commonly used.

Reason: all the entities (trees) are using lon for coordinates.


Some hints:

@RubenSmn RubenSmn added the good first issue Good for newcomers label Nov 1, 2022
@RubenSmn
Copy link
Member Author

RubenSmn commented Nov 1, 2022

Prerequisite: Greenstand/treetracker-web-map-core#127

@keyy123
Copy link
Contributor

keyy123 commented Dec 1, 2022

I would like to tackle this issue! @RubenSmn. Git won't allow me to push changes since I only changed the text :( .

@RubenSmn
Copy link
Member Author

RubenSmn commented Dec 2, 2022

Hmm that is weird, so you can't make a PR?

PS before your changes get merged this requires for this to be merged 😉

@keyy123
Copy link
Contributor

keyy123 commented Dec 2, 2022

🤣 That's comedy. Alright, I will wait until the changes are pushed into web-map API @RubenSmn! Thank you for telling me!

@dadiorchen
Copy link
Collaborator

This is too difficult to change, let's close it for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants