New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing BZIP2 compression #424

Open

GregHib opened this issue Jan 22, 2024 · 0 comments

Labels

bug performance

Owner

GregHib commented Jan 22, 2024

RemoveBzip2.kt breaks decompression on a few files meaning the client can't load 100% of the cache.

I suspect it's cause by https://github.com/Displee/rs-cache-library/blob/ec4c1bb7ad0b2166117d0720803e87a1609e1f20/src/main/kotlin/com/displee/cache/index/Index.kt#L79 trimming the revision, but if there's no revision it'll just trim the end of the data https://github.com/Displee/rs-cache-library/blob/ec4c1bb7ad0b2166117d0720803e87a1609e1f20/src/main/kotlin/com/displee/compress/CompressionExt.kt#L22.

Needs further investigation.

GregHib added the bug label

GregHib added the performance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment