From 102ceecb14c7fef7f52d866416067e4c5d93387e Mon Sep 17 00:00:00 2001 From: screret <68943070+screret@users.noreply.github.com> Date: Mon, 29 Jul 2024 22:23:47 +0300 Subject: [PATCH 1/4] update all dependencies JEI still crashes and I can't figure out why --- dependencies.gradle | 4 ++-- settings.gradle | 24 +++++++------------ .../gtceu/common/entity/DynamiteEntity.java | 4 ++-- .../kjs/builders/block/CoilBlockBuilder.java | 2 +- .../kjs/recipe/GTRecipeSchema.java | 7 +++--- .../kjs/recipe/IDRecipeConstructor.java | 9 ++++--- 6 files changed, 23 insertions(+), 27 deletions(-) diff --git a/dependencies.gradle b/dependencies.gradle index ebeff50b35..7e69c04a18 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -20,7 +20,7 @@ dependencies { // JEI jeiCompileOnly(forge.jei.common.api) { transitive = false } jeiCompileOnly(forge.jei.forge.api) { transitive = false } - jeiCompileOnly(forge.jei.forge.impl) { transitive = false } + jeiImplementation(forge.jei.forge.impl) { transitive = false } // REI reiCompileOnlyApi forge.rei.plugin @@ -29,7 +29,7 @@ dependencies { // EMI emiCompileOnlyApi("dev.emi:emi-neoforge:${forge.versions.emi.get()}:api") - emiImplementation forge.emi + emiCompileOnly forge.emi // TOP topCompileOnlyApi(forge.theoneprobe) { transitive = false } diff --git a/settings.gradle b/settings.gradle index eafd471107..c5d371c43e 100644 --- a/settings.gradle +++ b/settings.gradle @@ -18,21 +18,18 @@ dependencyResolutionManagement { versionCatalogs { // Minecraft Version def minecraftVersionVeryOld = "1.20.1" - def minecraftVersionOld = "1.20.4" - def minecraftVersionOldish = "1.20.6" def minecraftVersion = "1.21" // Mod Dependencies Versions // Common - def jeiVersion = "19.0.0.1" - def reiVersion = "16.0.729" + def jeiVersion = "19.5.2.66" + def reiVersion = "16.0.744" def emiVersion = "1.1.10" - def ae2Version = "18.1.3-alpha" - def kjsVersion = "2100.7.0-build.79" - def auVersion = "1.20.1-0.6.0" + def ae2Version = "19.0.4-alpha" + def kjsVersion = "2100.7.0-build.117" // NeoForge - def neoForgeVersion = "21.0.40-beta" + def neoForgeVersion = "21.0.143" def registrateForgeVersion = "MC1.21-1.3.0+16" def createForgeVersion = "0.5.1.d-9" def flywheelForgeVersion = "0.6.9-5" @@ -46,10 +43,10 @@ dependencyResolutionManagement { def spotlessVersion = "6.25.0" def vineFlowerVersion = "1.+" def macheteVersion = "1.+" - def configurationVersion = "5446773" - def ldLibVersion = "1.0.26.a" + def configurationVersion = "5573796" + def ldLibVersion = "1.0.26.b" def shimmerVersion = "0.2.2" - def neogradleVersion = "7.0.145" + def neogradleVersion = "7.0.157" forge { version("forgeShortVersion", neoForgeVersion) @@ -101,17 +98,12 @@ dependencyResolutionManagement { def ae2 = version("ae2", ae2Version) library("ae2", "appeng", "appliedenergistics2-neoforge").versionRef(ae2) - - def au = version("au", auVersion) - library("almostUnified-forge", "com.almostreliable.mods", "almostunified-forge").versionRef(au) } libs { version("parchment", parchmentVersion) version("minecraft", minecraftVersion) - version("minecraftOldish", minecraftVersionOldish) - version("minecraftOld", minecraftVersionOld) version("minecraftVeryOld", minecraftVersionVeryOld) def shadow = version("shadow", shadowVersion) diff --git a/src/main/java/com/gregtechceu/gtceu/common/entity/DynamiteEntity.java b/src/main/java/com/gregtechceu/gtceu/common/entity/DynamiteEntity.java index f7a7c2ba55..72d26190c1 100644 --- a/src/main/java/com/gregtechceu/gtceu/common/entity/DynamiteEntity.java +++ b/src/main/java/com/gregtechceu/gtceu/common/entity/DynamiteEntity.java @@ -32,8 +32,8 @@ public DynamiteEntity(LivingEntity throwerIn, Level worldIn) { } @Override - public void onAddedToWorld() { - super.onAddedToWorld(); + public void onAddedToLevel() { + super.onAddedToLevel(); ticksUntilExplosion = 80 + level().random.nextInt(60); } diff --git a/src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/block/CoilBlockBuilder.java b/src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/block/CoilBlockBuilder.java index 67c64e38ab..1df2c2913a 100644 --- a/src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/block/CoilBlockBuilder.java +++ b/src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/block/CoilBlockBuilder.java @@ -39,7 +39,7 @@ public CoilBlockBuilder coilMaterial(@NotNull Supplier<@Nullable Material> mater } @Override - public void generateAssetJsons(KubeAssetGenerator generator) {} + public void generateAssets(KubeAssetGenerator generator) {} @Override protected ItemBuilder getOrCreateItemBuilder() { diff --git a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java index a831142e46..f90e5a6f7f 100644 --- a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java +++ b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java @@ -19,6 +19,7 @@ import com.lowdragmc.lowdraglib.Platform; +import dev.latvian.mods.kubejs.util.KubeResourceLocation; import net.minecraft.nbt.CompoundTag; import net.minecraft.nbt.Tag; import net.minecraft.resources.ResourceLocation; @@ -73,10 +74,10 @@ class GTKubeRecipe extends KubeRecipe { @HideFromJS @Override - public GTKubeRecipe id(ResourceLocation _id) { + public GTKubeRecipe id(KubeResourceLocation _id) { this.idWithoutType = ResourceLocation.fromNamespaceAndPath( - _id.getNamespace().equals("minecraft") ? this.type.id.getNamespace() : _id.getNamespace(), - _id.getPath()); + _id.wrapped().getNamespace().equals("kubejs") ? this.type.id.getNamespace() : _id.wrapped().getNamespace(), + _id.wrapped().getPath()); this.id = ResourceLocation.fromNamespaceAndPath(idWithoutType.getNamespace(), "%s/%s".formatted(this.type.id.getPath(), idWithoutType.getPath())); return this; diff --git a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java index c0df80eb00..d45d092bb4 100644 --- a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java +++ b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java @@ -5,7 +5,9 @@ import dev.latvian.mods.kubejs.recipe.component.ComponentValueMap; import dev.latvian.mods.kubejs.recipe.schema.RecipeConstructor; import dev.latvian.mods.kubejs.recipe.schema.RecipeSchemaType; +import dev.latvian.mods.kubejs.script.SourceLine; import dev.latvian.mods.kubejs.util.Cast; +import dev.latvian.mods.kubejs.util.KubeResourceLocation; import dev.latvian.mods.rhino.Context; public class IDRecipeConstructor extends RecipeConstructor { @@ -14,9 +16,10 @@ public IDRecipeConstructor() { super(GTRecipeSchema.ID); } - public KubeRecipe create(Context cx, RecipeTypeFunction type, RecipeSchemaType schemaType, ComponentValueMap from) { - var r = super.create(cx, type, schemaType, from); - r.id(from.getValue(cx, r, GTRecipeSchema.ID)); + @Override + public KubeRecipe create(Context cx, SourceLine sourceLine, RecipeTypeFunction type, RecipeSchemaType schemaType, ComponentValueMap from) { + var r = super.create(cx, sourceLine, type, schemaType, from); + r.id(KubeResourceLocation.wrap(from.getValue(cx, r, GTRecipeSchema.ID))); return r; } From 1acec7def6077a34493d3ac7ef0683a0c925c1f3 Mon Sep 17 00:00:00 2001 From: screret <68943070+screret@users.noreply.github.com> Date: Mon, 29 Jul 2024 22:24:40 +0300 Subject: [PATCH 2/4] change back to EMI --- dependencies.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dependencies.gradle b/dependencies.gradle index 7e69c04a18..ebeff50b35 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -20,7 +20,7 @@ dependencies { // JEI jeiCompileOnly(forge.jei.common.api) { transitive = false } jeiCompileOnly(forge.jei.forge.api) { transitive = false } - jeiImplementation(forge.jei.forge.impl) { transitive = false } + jeiCompileOnly(forge.jei.forge.impl) { transitive = false } // REI reiCompileOnlyApi forge.rei.plugin @@ -29,7 +29,7 @@ dependencies { // EMI emiCompileOnlyApi("dev.emi:emi-neoforge:${forge.versions.emi.get()}:api") - emiCompileOnly forge.emi + emiImplementation forge.emi // TOP topCompileOnlyApi(forge.theoneprobe) { transitive = false } From 8df6b619d4753c3dfb9b6b48b72159811a9f51bf Mon Sep 17 00:00:00 2001 From: screret <68943070+screret@users.noreply.github.com> Date: Wed, 31 Jul 2024 20:14:03 +0300 Subject: [PATCH 3/4] spotless --- .../gtceu/integration/kjs/recipe/GTRecipeSchema.java | 5 +++-- .../gtceu/integration/kjs/recipe/IDRecipeConstructor.java | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java index f90e5a6f7f..969b0c34ed 100644 --- a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java +++ b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/GTRecipeSchema.java @@ -19,7 +19,6 @@ import com.lowdragmc.lowdraglib.Platform; -import dev.latvian.mods.kubejs.util.KubeResourceLocation; import net.minecraft.nbt.CompoundTag; import net.minecraft.nbt.Tag; import net.minecraft.resources.ResourceLocation; @@ -36,6 +35,7 @@ import dev.latvian.mods.kubejs.recipe.component.TimeComponent; import dev.latvian.mods.kubejs.recipe.schema.KubeRecipeFactory; import dev.latvian.mods.kubejs.recipe.schema.RecipeSchema; +import dev.latvian.mods.kubejs.util.KubeResourceLocation; import dev.latvian.mods.kubejs.util.TickDuration; import dev.latvian.mods.rhino.util.HideFromJS; import lombok.Getter; @@ -76,7 +76,8 @@ class GTKubeRecipe extends KubeRecipe { @Override public GTKubeRecipe id(KubeResourceLocation _id) { this.idWithoutType = ResourceLocation.fromNamespaceAndPath( - _id.wrapped().getNamespace().equals("kubejs") ? this.type.id.getNamespace() : _id.wrapped().getNamespace(), + _id.wrapped().getNamespace().equals("kubejs") ? this.type.id.getNamespace() : + _id.wrapped().getNamespace(), _id.wrapped().getPath()); this.id = ResourceLocation.fromNamespaceAndPath(idWithoutType.getNamespace(), "%s/%s".formatted(this.type.id.getPath(), idWithoutType.getPath())); diff --git a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java index d45d092bb4..c1d31f500f 100644 --- a/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java +++ b/src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/IDRecipeConstructor.java @@ -17,7 +17,8 @@ public IDRecipeConstructor() { } @Override - public KubeRecipe create(Context cx, SourceLine sourceLine, RecipeTypeFunction type, RecipeSchemaType schemaType, ComponentValueMap from) { + public KubeRecipe create(Context cx, SourceLine sourceLine, RecipeTypeFunction type, RecipeSchemaType schemaType, + ComponentValueMap from) { var r = super.create(cx, sourceLine, type, schemaType, from); r.id(KubeResourceLocation.wrap(from.getValue(cx, r, GTRecipeSchema.ID))); return r; From 4f9c590773ca06052d229db41d68ce0d3b7654c7 Mon Sep 17 00:00:00 2001 From: screret <68943070+screret@users.noreply.github.com> Date: Sat, 3 Aug 2024 20:14:11 +0300 Subject: [PATCH 4/4] try to fix action? --- .github/actions/build_setup/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/build_setup/action.yml b/.github/actions/build_setup/action.yml index 1d7089b48e..2bd2d78c85 100644 --- a/.github/actions/build_setup/action.yml +++ b/.github/actions/build_setup/action.yml @@ -5,7 +5,7 @@ inputs: update-cache: description: If cache should be updated required: false - default: 'true' + default: 'false' runs: using: 'composite'