Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonical type for type "function" isn't "bytes24" #3

Open
esaulpaugh opened this issue Jul 16, 2022 · 0 comments
Open

canonical type for type "function" isn't "bytes24" #3

esaulpaugh opened this issue Jul 16, 2022 · 0 comments

Comments

@esaulpaugh
Copy link

esaulpaugh commented Jul 16, 2022

I believe, based on the ethereum ABI spec and confirmed using Remix, that the function selector should be computed using the string "function" for function types and that "function" shall be used in the ABI json as well, and not "bytes24", despite function types having an identical encoding to bytes24 in the calldata. I believe 4byte is also incorrectly using "bytes24" to compute the selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant