Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with grouped tasks(split panels): Always restarting the last task #18

Open
OrIOg opened this issue May 2, 2020 · 3 comments
Open
Assignees
Labels

Comments

@OrIOg
Copy link

OrIOg commented May 2, 2020

I have a 3 grouped tasks, and I'm restarting the Socketio task when I update a specific file.
I'm launching my tasks with my default task Start.

I've found that when I save, whatever the depends order of my task, it will always close the last task (here Watch) then try to start the correct task (here Socketio).

Tasks.json

{
	"version": "2.0.0",
	"tasks": [
		{
			"label": "Start",
			"runOptions": {
				"instanceLimit": 1
			},
			"group": {
				"kind": "build",
				"isDefault": true
			},
			"dependsOn": [
				"Serve",
				"Socketio",
				"Watch",
			],
		},
		{
			"label": "Serve",
			"runOptions": {
				"instanceLimit": 1
			},
			"group": "build",
			"type": "shell",
			"command": "php artisan serve",
			"presentation": {
				"reveal": "always",
				"panel": "dedicated",
				"group": "Dev"
			}
		},
		{
			"label": "Socketio",
			"runOptions": {
				"instanceLimit": 1
			},
			"group": "build",
			"type": "shell",
			"command": "node socket.js",
			"presentation": {
				"reveal": "always",
				"panel": "dedicated",
				"group": "Dev"
			}
		},
		{
			"runOptions": {
				"instanceLimit": 1
			},
			"type": "npm",
			"script": "watch",
			"label": "Watch",
			"detail": "npm run development -- --watch",
			"group": "build",
			"presentation": {
				"reveal": "always",
				"group": "Dev",
				"panel": "dedicated"
			}
		},
	]
}

Settings.json

...

    "triggerTaskOnSave.on": true,
    "triggerTaskOnSave.showStatusBarToggle": true,
    "triggerTaskOnSave.restart": true,
    "triggerTaskOnSave.tasks": {
        "Socketio" : [
            "socket.js",
        ]
    }

...

@Gruntfuggly Gruntfuggly self-assigned this May 12, 2020
@Gruntfuggly
Copy link
Owner

Hi - could you post your config so I can try and reproduce this? How are the tasks grouped?

@OrIOg
Copy link
Author

OrIOg commented May 22, 2020

I made a basic project to test the bug
Test Project

Steps:

  1. Run build task( default task already set)
  2. Edit edit_to_reload.js
  3. Task should try to reload but terminate the last grouped task(here Sample2)
  4. Try to start the correct task but it is still active
  5. Popup message

@Gruntfuggly
Copy link
Owner

Thanks - I'll take a look at this tomorrow.

@OrIOg OrIOg changed the title Bug with rouped tasks(split panels): Always restarting the last task Bug with grouped tasks(split panels): Always restarting the last task Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants