Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Relto Book Share Clickspam #1606

Open
Attagoat opened this issue Jul 31, 2024 · 3 comments
Open

Fix Relto Book Share Clickspam #1606

Attagoat opened this issue Jul 31, 2024 · 3 comments

Comments

@Attagoat
Copy link

I am not a part of the guild of greeters although I like helping people who are new to the Cavern.

One of the issues that new people seem to do constantly is spam click the relto book on the person that they are sharing the relto book with.

This causes the relto book to flash on screen for the other person making it hard for them to link to relto.

Would it be possible to fix this by disabling spamclicking when the book has been shared with a player?

-Atticus "Attagoat" Kaphaem.

@Deledrius
Copy link
Member

Great suggestion! That sounds like something that should be fixable.

@dpogue
Copy link
Member

dpogue commented Jul 31, 2024

This comment feels potentially relevant here:

// Currently, there's nothing that removes these coop coordinators when
// they're done. Since I can't think of a good way to figure out when
// they're done, I'm just going to clear them every time a new one starts.
// With the current usage, you should only get one at a time anyway -Colin

So when a new share is triggered, it kills the old one and starts a new one, which is what causes the book GUI to keep spamming up.

There's a plCoopCoordinator::IsActiveForReal() method that gets used in a bunch of other spots in the avatar mgr to determine if a share is still in progress, so maybe we can find a way to use that to prevent sharing when an active share is already happening?

@Attagoat
Copy link
Author

Attagoat commented Aug 5, 2024

Just another suggestion to add to this idea: Would it be possible to send a message to let players know that the sharing of the relto book was accepted/denied? like if the avatar they are sharing the relto book with clicks off of the relto book the game lets them know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants