Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetDllPathFromAppConfig Not Considering Existing Keys #184

Open
MrMontana1889 opened this issue Jan 18, 2023 · 7 comments
Open

GetDllPathFromAppConfig Not Considering Existing Keys #184

MrMontana1889 opened this issue Jan 18, 2023 · 7 comments

Comments

@MrMontana1889
Copy link

If a program has keys specified in its config file that is NOT "NativeDependenciesAbsolutePath", then a NullReferenceException occurs on line 31 in NativeDependencies.cs where it attempts to get the path.

A null check should be added for the NativePathString key before attempting to get the value.

In the short term, I can clone and make the change locally, but this should be officially fixed and released.

This is a blocking issue for me.

@Apollo3zehn
Copy link

Is HDF.PInvoke.1.10 working for you? It uses as different library resolution process.

@MrMontana1889
Copy link
Author

Unfortunately, I can't use 1.10 right now since we are using 1.8 when writing results. We're hoping to move to 1.10 at some point down the road.

I have the fix locally and I can use that build for the time being, but it would be nice to use an official build of the library rather than building it locally.

@Apollo3zehn
Copy link

@gheber, would you accept a PR fixing this and publish a patch release on Nuget?

If yes, @MrMontana1889 , could you please create a PR?

@PhilPJL
Copy link

PhilPJL commented Jan 19, 2023

@MrMontana1889. I'm pretty sure version 1.10 saves by default in 1.8 format so using 1.10 should work fine for you. You can override this behaviour using set_libver_bounds.

@gheber
Copy link
Member

gheber commented Jan 20, 2023

@MrMontana1889. I'm pretty sure version 1.10 saves by default in 1.8 format so using 1.10 should work fine for you. You can override this behaviour using set_libver_bounds.

Yes.

@gheber
Copy link
Member

gheber commented Jan 20, 2023

@gheber, would you accept a PR fixing this and publish a patch release on Nuget?

If yes, @MrMontana1889 , could you please create a PR?

Yes.

@MrMontana1889
Copy link
Author

I'll give it a shot tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants