-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no ETag in the response header #240
Comments
The Tencent docs say the ETag is supported (see https://main.qcloudimg.com/raw/document/intl/product/pdf/436_14102_en.pdf), so I'd have expected it to work. If you look through the DN logs, do you see a line like: "s3Client.get_key_stats, expected to find key: ETag"? |
I checked the DN log, but I didn't see anything related to ETag. |
Do you see any DN lines like: INFO> head: ...? |
@jreadey No, I don't see any |
I might have not correctly understood the issue... HSDS gets the ETags for each object as part of the "scanRoot" operation, but this is not returned in the GET /datasets response. |
@jreadey Yes, I have got MD5 line when I do |
Ok, I see that. Not sure why the Etag key disappeared from the response header. Possibly this was the default in an earlier version of the aiohttp package, but not with the version we are using now. It shouldn't be hard to restore the etag response, but let me ask about the semantics you are expecting... With GET /datasets/datasetid/value, do you want the etag to represent the state of all the dataset values, or just the selection specified in the request? For GET /datasets/datasetid, it seems clear that the etag should represent the dataset values combined with any metadata (e.g. attributes). Are you thinking to use a HEAD request first to determine if anything has changed, and only do a GET when the values have changed? |
@jreadey Thank you very much for your reply. Yes, what you said is exactly what I want, I want thinking to use a HEAD request first to determine if anything has changed, and only do a GET when the values have changed. With GET /datasets/datasetid/value, I want the etag to represent the status of the selection specified in the request. Thank you again! |
Yes, that sounds useful. I created a feature issue for this here: #268. |
That's good idea! I will try to do a GET on the dataset and check the modification time. |
Hello, I found that when I got the value of dataset, there was no ETag in the response header information. May I ask what caused this?
The text was updated successfully, but these errors were encountered: