Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not updated on training-center website #1588

Closed
martamaja10 opened this issue Sep 18, 2024 · 9 comments
Closed

Links not updated on training-center website #1588

martamaja10 opened this issue Sep 18, 2024 · 9 comments
Assignees

Comments

@martamaja10
Copy link
Contributor

My PR to update the ROOT links: https://hsf-training.org/training-center/ was merged two days ago, but the website hasn't updated and the old course is still linked. Also, if I try to go into About I get the file not found error: https://hepsoftwarefoundation.org/workinggroups/training.html .

I also slightly modified the ROOT GSOC description and that part worked fine.

@graeme-a-stewart
Copy link
Member

Hi @jpivarski @amorenobr - could you take a look? Is this to do with the way the new training centre is coded? Like a different repo?

@jpivarski
Copy link
Contributor

@ariostas, do you see what the issue is? #1584 updated

  • _data/training-modules.yaml
  • _gsocprojects/2024/project_ROOT.md

What is the intended pathway for changes in these source files to update the final HTML?

@ariostas
Copy link
Contributor

@martamaja10, the training center was moved to https://github.com/hsf-training/training-center since now it's not Jekyll based.

I hadn't removed the training center data from this repo in case we had to roll back, but now it's just making things confusing. Sorry about that! I'll open a PR to remove things and point people to the new repo.

@jpivarski
Copy link
Contributor

That's a good idea. There should be one "source of truth." I think we're now well past the phase where we think we might be rolling back.

Can the old URL be an automatic redirect to the new one?

@ariostas
Copy link
Contributor

Can the old URL be an automatic redirect to the new one?

Yeah, the old URL already redirects to the new one, but on GitHub it's not clear that it moved somewhere else

@martamaja10
Copy link
Contributor Author

Thanks for the clarification, I now opened a PR on the other github page, would be great if someone could review and merge it, thanks! hsf-training/training-center#94

@ariostas
Copy link
Contributor

Could someone with the right permissions review and merge #1589? I merged hsf-training/training-center#94, so we can close this issue after that.

@amorenobr
Copy link
Contributor

Done!

@graeme-a-stewart
Copy link
Member

Thanks for the fix @ariostas and for raising the issue @martamaja10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants