-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links not updated on training-center website #1588
Comments
Hi @jpivarski @amorenobr - could you take a look? Is this to do with the way the new training centre is coded? Like a different repo? |
@martamaja10, the training center was moved to https://github.com/hsf-training/training-center since now it's not Jekyll based. I hadn't removed the training center data from this repo in case we had to roll back, but now it's just making things confusing. Sorry about that! I'll open a PR to remove things and point people to the new repo. |
That's a good idea. There should be one "source of truth." I think we're now well past the phase where we think we might be rolling back. Can the old URL be an automatic redirect to the new one? |
Yeah, the old URL already redirects to the new one, but on GitHub it's not clear that it moved somewhere else |
Thanks for the clarification, I now opened a PR on the other github page, would be great if someone could review and merge it, thanks! hsf-training/training-center#94 |
Could someone with the right permissions review and merge #1589? I merged hsf-training/training-center#94, so we can close this issue after that. |
Done! |
Thanks for the fix @ariostas and for raising the issue @martamaja10 |
My PR to update the ROOT links: https://hsf-training.org/training-center/ was merged two days ago, but the website hasn't updated and the old course is still linked. Also, if I try to go into About I get the file not found error: https://hepsoftwarefoundation.org/workinggroups/training.html .
I also slightly modified the ROOT GSOC description and that part worked fine.
The text was updated successfully, but these errors were encountered: