From 1c5d298e0dabe5726cfd04447a212dabff7bab3c Mon Sep 17 00:00:00 2001 From: knoellle Date: Tue, 13 Jun 2023 12:24:06 +0200 Subject: [PATCH] Remove reference to avoid cloning --- crates/source_analyzer/src/cyclers.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/crates/source_analyzer/src/cyclers.rs b/crates/source_analyzer/src/cyclers.rs index b52b49f66b..7356f655aa 100644 --- a/crates/source_analyzer/src/cyclers.rs +++ b/crates/source_analyzer/src/cyclers.rs @@ -34,9 +34,9 @@ impl Cyclers { manifest: FrameworkManifest, root: impl AsRef, ) -> Result { - let values = &manifest.cyclers; - let cyclers = values - .iter() + let cyclers = manifest + .cyclers + .into_iter() .map(|manifest| Cycler::try_from_manifest(manifest, root.as_ref())) .collect::>()?; Ok(Self { cyclers }) @@ -94,10 +94,9 @@ pub struct Cycler { } impl Cycler { - fn try_from_manifest(cycler_manifest: &CyclerManifest, root: &Path) -> Result { + fn try_from_manifest(cycler_manifest: CyclerManifest, root: &Path) -> Result { let instance_names = cycler_manifest .instances - .clone() .unwrap_or_else(|| vec![String::new()]); let instances = instance_names .iter() @@ -117,7 +116,7 @@ impl Cycler { .collect::, _>>()?; Ok(Cycler { - name: cycler_manifest.name.clone(), + name: cycler_manifest.name, kind: cycler_manifest.kind, instances, setup_nodes,