-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tap area on liking messages #1861
Comments
I am interested in contributing as a first-timer! I'd like to see if I can fix this. |
Hi @LadyAudrey - Yup that is correct! Ideally we'd like to keep the "size" of the view but make the tap area bigger (So if a player were to press slightly outside the Like, it would still Like/Dislike the message). If you have any other questions please feel free to ask! |
Hi! Took me a bit to re-orient post bootcamp, but I am downloading this now. Excited! |
@LadyAudrey marked this issue for you! good luck 🎊 |
Hi! I'm sorry I've been so slow about this. I've decided as much as I'd like to pivot into Android dev, I don't have the bandwidth to do so while job hunting; I've tried and tried to get this to run locally and I haven't been successful. I'm sorry to hold up the process! |
@LadyAudrey no worries! thanks for letting us know and best of luck out there |
Hey all! I added a PR to make the entire like container clickable (currently, it's just the + text itself): #2052. Just wanted to note that Google recommends a tap target size of at least 48dp width/height for a11y (link), so lmk if you wanted me to adjust this view to be a bit larger and fit that spec. While investigating this I found some general issues with liking messages that I notated in #2051. I left some notes there and will come back to investigate more when I have some more time, but I separated those issues out into their own ticket since it isn't being caused by the tap target being too small. |
Sometimes it can be difficult to tap the right area to like a message, we should take a look at that tap area and see if we can make it easier to tap.
The text was updated successfully, but these errors were encountered: