Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier site check fail #424

Open
IanWearsHat opened this issue Dec 5, 2024 · 2 comments
Open

Prettier site check fail #424

IanWearsHat opened this issue Dec 5, 2024 · 2 comments

Comments

@IanWearsHat
Copy link
Member

Now that Prettier Reviewdog reviews the full codebase, many site checks for PRs fail as a result.

Unless there's a better way to fix this, it should be as simple as formatting all documents that Prettier can affect.

image

@taesungh
Copy link
Member

taesungh commented Dec 5, 2024

Partly addressed in 63737fb by changing filter to file, sorry for the inconvenience. Older files still need to be reformatted (and unused things like Fireflies could also be deleted).

@Bl20052005
Copy link
Contributor

Issues with older files are addressed in #413, once merged the formatting issues should mostly go away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants