Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docgen vs. tracy #11789

Closed
Simn opened this issue Oct 15, 2024 · 3 comments
Closed

Docgen vs. tracy #11789

Simn opened this issue Oct 15, 2024 · 3 comments

Comments

@Simn
Copy link
Member

Simn commented Oct 15, 2024

+ make -s xmldoc
Local repository created (/home/runner/work/haxe/haxe/extra/.haxelib/)
Installing hxcpp from https://github.com/HaxeFoundation/hxcpp
  Current version is now git
Done
Installing hxjava from https://github.com/HaxeFoundation/hxjava
  Current version is now git
Done
 WARNING  /home/runner/work/haxe/haxe/std/neko/vm/Ui.hx:67: characters 15-19

 67 |   var l = new Lock();
    |               ^^^^
    | (WDeprecated) This typedef is deprecated in favor of sys.thread.Lock

 WARNING  /home/runner/work/haxe/haxe/std/cpp/net/ThreadServer.hx:31: characters 8-14

 31 |  var t:Thread;
    |        ^^^^^^
    | (WDeprecated) This typedef is deprecated in favor of sys.thread.Thread

 ERROR  /home/runner/work/haxe/haxe/std/cpp/vm/tracy/TracyProfiler.hx:26: characters 8-58

 26 | #error "This class cannot be used without -D HXCPP_TRACY"
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | This class cannot be used without -D HXCPP_TRACY

make: *** [Makefile:[17](https://github.com/HaxeFoundation/haxe/actions/runs/11341552080/job/31540055616?pr=11768#step:11:18)5: xmldoc] Error 1
Error: Process completed with exit code 2.

cc @dazKind

@dazKind
Copy link
Contributor

dazKind commented Oct 15, 2024

@Simn Oh, didnt think of docgen when adding the guard. I disabled it for the moment

@Simn
Copy link
Member Author

Simn commented Oct 15, 2024

Yes I think that's best.

It's a bit silly that docgen doesn't run on PRs because we sometimes come across problems like this after merging.

@Simn
Copy link
Member Author

Simn commented Oct 15, 2024

Fixed by #11790

@Simn Simn closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants