Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only treat negative values as missing values for log transformation #9

Open
eschen42 opened this issue May 27, 2021 · 1 comment
Open
Assignees

Comments

@eschen42
Copy link
Collaborator

log-transformed data can have meaningful negative values. Issue #7 was applicable only when log-transforming data. Under all other circumstances, negative values must be treated as actual values and not converted to zero.

@eschen42 eschen42 added the bug label May 27, 2021
@eschen42 eschen42 self-assigned this May 27, 2021
@eschen42
Copy link
Collaborator Author

eschen42 commented May 27, 2021

Perhaps this is best addressed with a dropdown with two choices (the first as default):

  • "Do not alter negative values (e.g., for centered data)"
  • "Treat negative values as missing values".

The issue is not really whether data are log-transformed (MS intensities less than one are useless anyway) but rather whether the data are centered. If the tool is expected to respect centered data, then this issue is a bug; otherwise it's an enhancement. I am tentatively removing the bug label.

@eschen42 eschen42 added enhancement and removed bug labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant