-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use CongruenceQuotient to define coequalizer #2035
Comments
I think it would also be helpful to allow a subgroup of a group to be defined with a predicate that isn't assume to take values in h-propositions. This would avoid us needing to |
#2057 does this.
#2057 alone doesn't simplify anything else, since those section variables were ignored. What would help would be to directly define coequalizers as the quotient by a non-truncated congruence relations, and to define the quotient of a group by a not-necessarily truncated subgroup. |
@jdchristensen I've tried formalising this, but I don't follow your idea for the relation |
It seems to me, that we should really be using |
@Alizter I think you're right. Would it help things if we wrote it as |
That appears to have worked, but I have yet to see if it offers any simplifications elsewhere. |
I guess we'll at least save having to strip truncations and apply tr, since the predicate is not truncated. But we could also achieve that by allowing (some) subgroups to be specified by an untruncated predicate. Maybe some other algebra is simplified as well? |
@jdchristensen I've created a PR if you would like to take a closer look. #2060 |
We should experiment with using
CongruenceQuotient
to define the coequalizer of two maps between groups. This should avoid having to deal with terms of the form-foo * bar
. Givenf, g : A $-> B
, we probably want to defineR b b'
to be{ a : A & f a = b * g a = b' }
.We should also delete the hypothesis in the Section defining
ConguenceQuotient
that asserts that the relation is an hprop, since it is never used. So we'll also avoid having strip truncations and apply tr.Note that tensor products should simplify a bit as well.
If we do this, it's not clear whether to define the cokernel as the coequalizer against the zero map, or to keep the cokernel as the quotient by the image subgroup.
This is based on #2034 (comment)_
The text was updated successfully, but these errors were encountered: