Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalise criteria for feature inclusion in formulae #206404

Open
nandahkrishna opened this issue Feb 3, 2025 · 3 comments
Open

Formalise criteria for feature inclusion in formulae #206404

nandahkrishna opened this issue Feb 3, 2025 · 3 comments
Labels
maintainer feedback Additional maintainers' opinions may be needed

Comments

@nandahkrishna
Copy link
Member

nandahkrishna commented Feb 3, 2025

What were you proposing (and why)?

Formalise a policy on what features can be included in formulae (when is this fine, what dependencies would we want to avoid and why, etc.). This is a tracking issue to facilitate discussion and improve our documentation on what "extra" features we are generally okay with including, and when it is fine to do so – what's the minimum number of requests beyond which we include things, etc.

A clearly documented policy allows us to point users making feature requests to it, and also ensures standards are applied consistently across formulae and by all maintainers.

@nandahkrishna nandahkrishna added the maintainer feedback Additional maintainers' opinions may be needed label Feb 3, 2025
@MikeMcQuaid
Copy link
Member

Great idea 👏🏻

My take:

  • we should have a (minimal) algorithm for this e.g. a number of requests that exceeds the number of (recursive) dependencies this would add
  • we should consider having some ${FORMULA}-full/${FORMULA}-minimal formulae for maximal/minimal cases of formula and keep ${FORMULA} for "the functionality that we need for dependencies in Homebrew itself". This would likely help make e.g. ffmpeg significantly smaller in terms of dependencies (allowing more usage in more formulae)

@gromgit
Copy link
Contributor

gromgit commented Feb 3, 2025

  • we should consider having some ${FORMULA}-full/${FORMULA}-minimal formulae for maximal/minimal cases of formula and keep ${FORMULA} for "the functionality that we need for dependencies in Homebrew itself". This would likely help make e.g. ffmpeg significantly smaller in terms of dependencies (allowing more usage in more formulae)

Sounds like that would require ${FORMULA} to be keg-only, in order to coexist with ${FORMULA}-full or ${FORMULA}-minimal. Alternatively, addressing Homebrew/brew#16398 might help resolve this in a user-friendly manner, where ${FORMULA} is pulled in as a dependency but users prefer ${FORMULA}-full for active use.

@MikeMcQuaid
Copy link
Member

Sounds like that would require ${FORMULA} to be keg-only, in order to coexist with ${FORMULA}-full or ${FORMULA}-minimal.

Yes, one or more of these would need to be keg-only.

users prefer ${FORMULA}-full for active use.

I'm not sure this will be the case for e.g. ffmpeg with a very deep dependency tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Development

No branches or pull requests

3 participants