New Formula: Inspectrum 0.1.1 #6146
Conversation
tduehr
force-pushed
the
inspectrum
branch
3 times, most recently
from
34074d5 to
370fce6
Compare
|
Keeps saying there are no tests but |
| end | ||
|
|
||
| test do | ||
| system "inspectrum -h" |
There was a problem hiding this comment.
Can this test be modified to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!
There was a problem hiding this comment.
not really...
-h does at least initialize parts of the gui...
Usage: inspectrum [options] file
spectrum viewer
Options:
-h, --help Displays this help.
-r, --rate <Hz> Set sample rate.
Arguments:
file File to view.
There was a problem hiding this comment.
Ok, that's fine. Please do system "#{bin}/inspectrum", "-h".
| depends_on "fftw" | ||
| depends_on "cmake" => :build | ||
| depends_on "pkg-config" => :build | ||
| depends_on "liquid-dsp" |
There was a problem hiding this comment.
Error: No available formula with the name "liquid-dsp"
There was a problem hiding this comment.
I forgot that's a tap dependency. https://github.com/dholm/homebrew-sdr/blob/master/liquid-dsp.rb
There was a problem hiding this comment.
Ok, that'll need to be fixed.
| depends_on "fftw" | ||
| depends_on "cmake" => :build | ||
| depends_on "pkg-config" => :build | ||
| depends_on "dholm/sdr/liquid-dsp" |
There was a problem hiding this comment.
Sorry, we don't want homebrew/core formulae to depend on non-homebrew/core formulae so we'll need liquid-dsp to get included first. This was blocked on them making a new stable release: #2664
|
Okay, I'll submit that too. |
|
@tduehr We need them to release a new stable release first. Please discuss this with upstream before opening a PR here, thanks. |
dunn
added
needs response
|
Closing due to inactivity/need for upstream release. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?