Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Formula: Inspectrum 0.1.1 #6146

Closed
wants to merge 1 commit into from
Closed

New Formula: Inspectrum 0.1.1 #6146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Formula/inspectrum.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
class Inspectrum < Formula
desc "Offline radio signal analyser"
homepage "https://github.com/miek/inspectrum"
url "https://github.com/miek/inspectrum/archive/v0.1.1.tar.gz"
sha256 "b139cd7978f294d4872a1e3e70a813f4e9600f7677da5b9f6c431b3fa7f7e03e"

depends_on "qt5"
depends_on "fftw"
depends_on "cmake" => :build
depends_on "pkg-config" => :build
depends_on "liquid-dsp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: No available formula with the name "liquid-dsp"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that's a tap dependency. https://github.com/dholm/homebrew-sdr/blob/master/liquid-dsp.rb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that'll need to be fixed.


def install
system "cmake", ".", *std_cmake_args
system "make", "install"
end

test do
system "inspectrum -h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test be modified to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really...

-h does at least initialize parts of the gui...

Usage: inspectrum [options] file
spectrum viewer

Options:
  -h, --help       Displays this help.
  -r, --rate <Hz>  Set sample rate.

Arguments:
  file             File to view.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's fine. Please do system "#{bin}/inspectrum", "-h".

end
end