Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid indexer polynomials produced when num_constraints is a power of two #3

Closed
DanieleDiBenedetto opened this issue Jan 25, 2021 · 1 comment

Comments

@DanieleDiBenedetto
Copy link
Collaborator

DanieleDiBenedetto commented Jan 25, 2021

As the title suggest, if in a circuit the number of constraints is exactly equal to a power of two, inconsistent indexer polynomials are produced. For instance:

Num constraints: 1024
a_row degree: 0
a_col degree: 1
a_val degree: 0
a_row_col degree: 1
b_row degree: 1023
b_col degree: 1
b_val degree: 1023
b_row_col degree: 1023
c_row degree: 1023
c_col degree: 1
c_val degree: 1023
c_row_col degree: 1023

This may be a porting error. Investigate and solve.

@DanieleDiBenedetto
Copy link
Collaborator Author

This issue is the same of arkworks-rs/poly-commit#40,
fixed by arkworks in arkworks-rs/poly-commit#55.
A similar fix has been commited also to our poly-commit in HorizenLabs/poly-commit@3eec3f4.
A unit test marlin side has been added too in 2589862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant