Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128000 and Lambda limits #238

Closed
3 tasks
brianraymor opened this issue Mar 22, 2019 · 1 comment
Closed
3 tasks

128000 and Lambda limits #238

brianraymor opened this issue Mar 22, 2019 · 1 comment
Labels
code review Low Low priority label

Comments

@brianraymor
Copy link

https://github.com/HumanCellAtlas/matrix-service/blob/master/matrix/lambdas/api/core.py#L47

    if not has_url and len(json.dumps(body['bundle_fqids'])) > 128000:

128000 is a magic value that future maintainers may not understand.

Consider:

  • Replacing the hardcoded value with a constant or variable that is self-documenting.
  • Adding a comment that documents the relationship to limits on Lambda invocation payloads
  • Updating the Swagger documentation to include the maximum size of bundle_fqids
@brianraymor brianraymor added Low Low priority label code review labels Mar 22, 2019
@brianraymor
Copy link
Author

Better documentation about the List of bundle fqids is too large. is implicit in #301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Low Low priority label
Projects
None yet
Development

No branches or pull requests

1 participant