Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD: Configure CI to run BDD tests #43

Closed
tk3369 opened this issue Mar 7, 2021 · 4 comments · Fixed by #116
Closed

BDD: Configure CI to run BDD tests #43

tk3369 opened this issue Mar 7, 2021 · 4 comments · Fixed by #116
Labels
enhancement New feature or request TODO Good for newcomers
Milestone

Comments

@tk3369
Copy link
Member

tk3369 commented Mar 7, 2021

Configure CI to run BDD process (pull feature files, install Grakn, and execute the tests)

@tk3369 tk3369 mentioned this issue Mar 7, 2021
7 tasks
@tk3369
Copy link
Member Author

tk3369 commented Mar 7, 2021

See #30 (comment)

Here's what I think would work:

  1. Create a GitHub action to set up Grakn server
  2. Create a GitHub action (or reuse an existing if available) to clone the BDD repo with feature files
  3. Write a test script that execute the feature files using ExecutableSpecifications.jl

As a developer, the local environment should have Grakn server and features available already. Then, doing ] test from the REPL should just include BDD tests.

@mkschulze
Copy link
Member

Perhaps we can use this here: https://github.com/marketplace/actions/github-action-for-bash

@mkschulze mkschulze added enhancement New feature or request TODO Good for newcomers labels Mar 8, 2021
@mkschulze mkschulze linked a pull request Mar 8, 2021 that will close this issue
@mkschulze mkschulze added this to the Version 1.0 milestone Mar 8, 2021
@mkschulze
Copy link
Member

I created a GitHub Action here: https://github.com/Humans-of-Julia/GraknRunner

Not sure yet, if we can do it all in one, but would be ideal I think.

It can be easily included in a workflow file like:

name: Grakn BDD runner
on: [push]

jobs:
  hello_world_job:
    runs-on: ubuntu-latest
    name: A job to pull feature files, install Grakn, and execute the tests
    steps:
    - uses: actions/checkout@v2
    - id: foo
      uses: Humans-of-Julia/[email protected]
      with:
        who-to-greet: 'Mark'
    - run: echo random-number ${{ steps.foo.outputs.random-number }}
      shell: bash

@mkschulze
Copy link
Member

See #30 (comment)

As a developer, the local environment should have Grakn server and features available already. Then, doing ] test from the REPL should just include BDD tests.

I'm curious here, would that mean the test has to run locally? Wouldn't it be cool to let it all run in the virtual machine in the GitHub Action runner?

@mkschulze mkschulze linked a pull request Sep 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TODO Good for newcomers
Projects
None yet
2 participants