Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwhisper crashes if the server does not support reflection #124

Open
Hendrik-H opened this issue Jan 21, 2022 · 3 comments
Open

gwhisper crashes if the server does not support reflection #124

Hendrik-H opened this issue Jan 21, 2022 · 3 comments
Labels
bug Something isn't working IRQ

Comments

@Hendrik-H
Copy link
Member

Describe the bug
When trying to connect to a server that does not support gRPC reflections then gWhisper crashes with a segfault. Would be nice if a message would be displayed instead that states that the server is missing the reflection support.

To Reproduce
just try to connect to a server that does not support reflection

Expected behavior
no crash but a clear message

@Hendrik-H Hendrik-H added the bug Something isn't working label Jan 21, 2022
@rainerschoe
Copy link
Member

Thanks for reporting this. We should indeed not crash but write an understandable error message.
We did until now not test on non-reflection server.
A;so see related issue: #5 which we plan to work on in the next months

@rainerschoe
Copy link
Member

in latest development version, as well as in latest release v3.3.1 I cannot reproduce.
output when connecting to non reflection server:

> gwhisper 127.0.0.1
Parse failed.Parsed until: '127.0.0.1'
Possible Candidates:
  '127.0.0.1:'
  '127.0.0.1'
  '127.0.0.1 '
Reflection request not implemented; is the ServerReflection service enabled?

could you please give details (gwhisper version) and example crash.

@Hendrik-H
Copy link
Member Author

I'm using v3.3.1 and am connecting from x86 to a none reflect enabled gRPC service running on 390. the result is

Segmentation fault (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IRQ
Projects
None yet
Development

No branches or pull requests

2 participants