Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add annotations to varnish cluster spec #110

Open
iahmad-khan opened this issue May 30, 2023 · 3 comments
Open

Need to add annotations to varnish cluster spec #110

iahmad-khan opened this issue May 30, 2023 · 3 comments

Comments

@iahmad-khan
Copy link

I need to add the following annotations to the cluster definition so that all other objects created by cluster definition ( such as stateful set and pods ) inherit these annotations, currently, it doesn't work.

annotations:
   prometheus.io/scrape: "true"
   prometheus.io/port: "9131" 
@cin
Copy link
Contributor

cin commented May 31, 2023

This repo currently isn't being maintained. I have started maintaining a fork of this repo w/the hopes of periodically getting things merged back here. Here's the fork location and podAnnotation config: https://github.com/cin/varnish-operator/blob/main/api/v1alpha1/varnishcluster_types.go#L93.

@iahmad-khan
Copy link
Author

@cin thanks. Does it mean do I need to reinstall the operator from the forked repo? and then reinstall the varnish cluster

@cin
Copy link
Contributor

cin commented Jun 12, 2023

Sorry for the delay. I was on vacation. In regard to your question about having to reinstall, I am not sure offhand. I have not altered the CRD's name or any of the main fields in the fork, so I think a regular upgrade should work. Have you had a chance to try this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants