Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PHP tests to PHP toolkit repo #21

Open
kadler opened this issue Jan 23, 2019 · 7 comments
Open

Migrate PHP tests to PHP toolkit repo #21

kadler opened this issue Jan 23, 2019 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kadler
Copy link
Member

kadler commented Jan 23, 2019

While we're converting the existing PHP tests to not use the PHP toolkit in #20, they may be useful to https://github.com/zendtech/IbmiToolkit. We should submit them over there.

@kadler kadler added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 23, 2019
@chukShirley
Copy link

We would appreciate them and a build server to run them on for CI builds, thanks! ;)

@kadler
Copy link
Member Author

kadler commented Jan 23, 2019

@chukShirley I'm building all the Python tests as unit tests with mocking. Eventually, I'd like some integration tests too, but with mocked unit tests, you can use something like TravisCI which is awesome.

@chukShirley
Copy link

Agreed, yes. I was specifically requesting an IBM i partition for running integration tests. It'd be useful for all client toolkits, really. I know this probably isn't the place to make the request, though.

@kadler
Copy link
Member Author

kadler commented Jan 23, 2019

Yep, I agree that's really needed. I'd love something like TravisCI for open source IBM i projects. Maybe Liam can get his barryCI going.

@alanseiden
Copy link
Collaborator

Let's pick one test to start with: https://github.com/IBM/xmlservice/blob/master/test/php/test_50100_ibm_db2_io_jvm_ZZJAVA.phpt (RPG Java test)

  • Migrate this PHP Toolkit-dependent test to the https://github.com/zendtech/IbmiToolkit repository
  • If there is no equivalent XMLSERVICE test to this Java one that does not rely on the PHP Toolkit, create one for this XMLSERVICE repository.

@alanseiden
Copy link
Collaborator

Note: There is a second PHP Toolkit - dependent test calling ZZJAVA.
https://github.com/IBM/xmlservice/blob/master/test/php/test_50110_ibm_db2_io_jvm_ZZJAVA2.phpt

@alanseiden
Copy link
Collaborator

alanseiden commented Jul 22, 2022

For reference in creating future tests, here is an XMLSERVICE test that does not need the PHP Toolkit. While written in PHP, it does NOT require the toolkit as a dependency. The test passes XML directly to the XMLSERVICE stored procedures.
https://github.com/IBM/xmlservice/blob/master/test/php/test_10120_ZZCALL_ibm_db2_io_pgm.phpt

This test uses the ibm_db2 transport. We could adapt it using the CLI transport to remove database depencency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants