Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean notebooks from sparqls #276

Open
altix opened this issue Mar 7, 2023 · 1 comment
Open

Clean notebooks from sparqls #276

altix opened this issue Mar 7, 2023 · 1 comment
Labels
fix Fix something that is working but not as intended.

Comments

@altix
Copy link
Collaborator

altix commented Mar 7, 2023

  1. In icos_jupyter_notebooks/as_obs_tools/icos_as_obs_tools.ipynb has a temporary fix that should be removed, just use station.getList('AS')
  2. The nb icos_jupyter_notebooks/availability_tools/icos_availability_tools.ipynb
  3. The nb: icos_jupyter_notebooks/icos_STILT/icos_stilt_tools.ipynb still imports from icoscp.sparql import sparqls, runsparql, but it is not used.
  4. In icos_jupyter_notebooks/availability_tools/icos_availability_tools.ipynb there are several sparqls that should be removed. Some analysis is needed though.
  5. icos_jupyter_notebooks/as_stat_tools/icos_as_stat_tools.ipynb has 15 sparqls that are not needed, a bit analysis is needed.
  6. The RINGO files: project_jupyter_notebooks\RINGO_T1.3\ICOS_flasksampling_fossilfuel.ipynb, \RINGO_T1.3\RINGO_T1.3_flasksampling_v5.ipynb, \RINGO_T1.3\modules\README.ipynb, \RINGO_T1.3\modules\README.md mentions a sparql-script which is gone.

Other notebooks and scripts that might need a look are found in: icos_jupyter_notebooks\radiocarbon, icos_jupyter_notebooks\radiocarbon, project_jupyter_notebooks\network-view-tool\network_view.

@altix altix added the fix Fix something that is working but not as intended. label Mar 7, 2023
@ukarst
Copy link
Collaborator

ukarst commented Mar 7, 2023

ad 6. RINGO files: The lines mentioning sparql in the notebooks and README files can be removed. Sparql queries are no longer used in these notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something that is working but not as intended.
Projects
None yet
Development

No branches or pull requests

2 participants