Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Models: conf.pth] Wrong data path in conf.pth-files of the provided models #20

Open
GregorKobsik opened this issue Mar 29, 2023 · 1 comment

Comments

@GregorKobsik
Copy link

GregorKobsik commented Mar 29, 2023

Description:

The provided conf.pth-files seem inconsistent with the provided dataset (cmp. Example below). The dataloader PartGraphShapesDataset uses the provided argument data_path for self.data_dir. Later, in the function __getitem__(...) the geometric data geo_data is loaded given the provided data path. Unfortunately, all .npz-files are located in Chair_dgeo directory and not in the Chair_dhier directory.

Is my assumption correct, that we need to manually update the configuration files to make it consistent with the provided dataset (or vice versa)?

Example (exp_ae_Chair):

{'exp_name': 'PartNet_ae_Chair_4000_ccc',
 'category': 'Chair',
 'device': 'cuda:0',
 'seed': 3124256514,
 'model_path': '../data/models',
 'data_path': '../data/partnetdata/Chair_dhier',     <-- inconsistent with dataset, no ".npz"-files
 'floor_data_path': '',
 'train_dataset': 'chair.txt',
...
 'max_part_per_parent': 10,
 'X': 12,
 'Y': 2}

DSG-Net/code/datav1.py

Lines 464 to 465 in 6c6d117

geo_fn = os.path.join(self.data_dir, self.pg_shapes[index][idx] + '.npz')
geo_data = np.load(geo_fn)

@GregorKobsik
Copy link
Author

GregorKobsik commented Mar 30, 2023

It seems like the provided models need to be called with different evaluation scripts.
eval.py uses the Chair_dgeo dir and eval_recon_sn.py uses Chair_dhier.

I start to suspect, that the derivation sn is used for StructureNet and the default evaluation scripts eval_vae_chair.sh runs a StructureNet example and not the model described in the published paper.

P.S.
I think it is the described SN-Mesh model, which uses a different dataset encoding/format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant