-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Adding a touristManager to the solution #17
Comments
Thanks for your contribution. This is a really good idea and something I think will be widely used where more than 1 tour is available. Right now I have a similar challenge - site "pages" where there is more than one potential tour, which I solve with a horrible hacky solution. I had some initial thoughts: You've added "title" and "description" to the tour options, I think these make sense to incorporate into Tourist anyway, even without the tour manager. I think we should consider making a dynamic tour manager. In your example you create your tour in the js, and then call addTour() for each tour. How about we turn this into a manager with a lazy load?
Then, in js/my_page_tours.js, you would have your normal tour options:
This would avoid the scenario where a page that has multiple tours (or even one massive single tour) loads them all into the DOM on page load. Then we include your tour manager ability to let users select their own tour etc, with templating etc. What do you think? I already see one issue to solve, which is the need to duplicate "title" and "description" properties in the options passed to the manager, and the individual tour options. Also, maybe we can incorporate the manager into Tourist itself, to avoid 2 plugins. This changes the paradigm slightly, because a Tourist instance now doesn't represent one tour but a possibility of multiple tours... Interesting discussion! |
Hi folks,
I started to build a small "Tour Manager" so that you can have multiple tours. With that, you would also have an overview of the tours and would be able to start them right away.
In the attached file, there is an example. A welcome modal with popup, linking to a starting tour. Another modal will show what tours are available. The welcome modal is hardcoded, but it could be easily adapted to be called via function.
I also had the idea to have something like a checkbox for tours that have already been seen until the end/or started in the overview modal.
What are your thoughts on this?
Thanks for the feedback!
touristManager.zip
The text was updated successfully, but these errors were encountered: