Why do EdgeChange operations have both an about_edge and {subject, predicate, object} slots?
#53
Comments
gouttegd
added a commit
to gouttegd/kgcl-java
that referenced
this issue
Sep 27, 2024
The KGCL model is somewhat inconsistent in that the EdgeChange class has
a 'about_edge' slot intended to represent the edge (as a {subject,
predicate, object} triple) that is being changed, but several of its
subclasses (EdgeCreation, EdgeDeletion, MoveUnder, PlaceUnder) _also_
have distinct 'subject', 'predicate', and 'object' slots, which are
redundant with the fields of the 'about_edge' slot.
I believe these slots are not only useless but also harmful, since it is
unclear how the corresponding classes are supposed to be used (i.e.,
should the subject be set in change.subject or in
change.about_edge.subject?). Since I strongly suspect these slots are
actually a mistake (and got no indication of the contrary when I raised
the issue to the KGCL folks [1]), here we update our code to only deal
with the 'about_edge' slot, and completely ignore the "flattened"
subject/object/predicate slots.
[1] INCATools/kgcl#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
EdgeChangeclass has anabout_edgeslot of rangeEdge, which itself has three slotssubject,predicate, andobjectto represent a typical RDF triple / OWL axiom / graph edge, etc.But several of the subclasses of
EdgeChangehave also their ownsubject,predicate,objectfields, in addition to theabout_edgethat they inherit fromEdgeChange. For exampleEdgeCreation,PlaceUnder,EdgeDeletion…Why is that so, and what is the intended way of using those classes? For example, is the subject of the edge to be created in
EdgeCreationintended to be stored inEdgeCreation.subjector inEdgeCreation.about_edge.subject?Other subclasses of
EdgeChangedon’t have their ownsubject,predicate,objectslots and have instead only theabout_edgeinherited fromEdgeChange(for exampleNodeMove), suggesting thatabout_edgeis the correct way to represent edges and that the “flattened”subject,predicate, andobjectslots in the other classes might be a mistake.The text was updated successfully, but these errors were encountered: