Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine stopped detecting end of the game #13

Open
kusayuzayushko opened this issue Jan 24, 2023 · 9 comments
Open

Engine stopped detecting end of the game #13

kusayuzayushko opened this issue Jan 24, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@kusayuzayushko
Copy link

image
image

@IOKernel
Copy link
Owner

I haven't been able to replicate this in the 3 matches I tried, it can detect end of game for me. I will check some more over the weekend and fix

@IOKernel IOKernel added the bug Something isn't working label Jan 24, 2023
@kusayuzayushko
Copy link
Author

Reinstalled the Sangatsu, registered new account and played two games - first one worked just fine, second one stuck at the end again so it's not an HTML, right? I also have issues with the initial login when i start the sangatsu - internet is kinda slow so loading takes time (5-10+ seconds, i guess) and 2 out of 3 times I'm ending up getting "play live" page, but I'm not logged in.
May it be related?

@IOKernel
Copy link
Owner

For the sign-in issue, you can edit line 96 in utils/helpers.py

time.sleep(8)

and increase the sleep after login to like 15 seconds

@IOKernel
Copy link
Owner

For the game it failed detect the ending of, were you playing white or black?
Did it end in checkmate or resignation?

@kusayuzayushko
Copy link
Author

first game: played as white, won by checkmate.
second game: played as black, won by resignation, game stuck

@SolsticeSpectrum
Copy link

Same issue. It might be problem with resignations.

@kusayuzayushko
Copy link
Author

kusayuzayushko commented Jan 25, 2023

The only games Sangatsu detects are checkmates. Not sure about repetitions, has anyone got them yet?
EDIT: Ended by time games are not detected as well.

@IOKernel
Copy link
Owner

The resignation issue is fixed, it detects game end state by checking the move-list. Draws don't add results to the move-list so they're still not detected

@SolsticeSpectrum
Copy link

The resignation issue is fixed, it detects game end state by checking the move-list. Draws don't add results to the move-list so they're still not detected

It also doesn't recognize auto-abort that happens on bullets when opponent doesn't make a move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants