Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo site: page language has not been identified #55

Closed
elynema opened this issue Oct 10, 2023 · 2 comments
Closed

Demo site: page language has not been identified #55

elynema opened this issue Oct 10, 2023 · 2 comments
Assignees

Comments

@elynema
Copy link

elynema commented Oct 10, 2023

Error from SiteImprove:

The main language of the page has not been declared within the element. Language tags tell screen readers how to pronounce the text on a page.

If language tags are missing or mistyped, the screen reader will revert to its default pronunciation settings. This could result in a strange or confusing experience for users who access content in more than one language.

image

image

See more details in SiteImprove.

@cjcolvar
Copy link

Original thoughts:

You'd think that this would be an easy fix but we don't directly control the head element in the index and app/index pages. These pages are generated using a template that is buried inside a set of JS libraries (FESK) used to build the app. It might be possible to override the template but I haven't been successful so far.

Updated:

In #60 I worked around this by overriding the entire generated html pages. This makes the nunjucks templates useless since they are getting entirely overwritten. The process for updating might be to update the nunjucks templates, run yarn fesk-build and then copying dist/index.html and dist/app/index.html out to overrides/dist and reapplying the customizations.

@elynema
Copy link
Author

elynema commented Feb 20, 2024

This is resolve on timeliner-staging; SiteImprove browser plugin is no longer complaining.

@elynema elynema closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants