Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the concurrent setup prevention opt-in #27

Open
vovimayhem opened this issue Feb 23, 2022 · 0 comments
Open

Make the concurrent setup prevention opt-in #27

vovimayhem opened this issue Feb 23, 2022 · 0 comments

Comments

@vovimayhem
Copy link
Contributor

#26 allowed to skip the concurrent setup lock, but the default behavior should be not to lock the setup at all.

Let's use an optional ON_CONTAINER_PREVENT_CONCURRENT_SETUP environment variable that prevents the concurrent setup instead.

Also, let's rename the on_setup_lock_acquired method with to_setup_container so the development entrypoint scripts look like this:

require 'on_container/dev/rails'

set_given_or_default_command

if command_requires_setup?
  to_setup_container do
    # Stuff to setup the container...
  end
end
@vovimayhem vovimayhem changed the title Make the concurrent setup lock opt-in Make the concurrent setup prevention opt-in Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant